We're updating the issue view to help you get more done. 

Logging Improvement when cannot connect to application.

Description

If a application is down which you have an application link set up for. The AppLinksActivityProvider spits out lots of horrible and unhelpful stacktraces. I think it would be better to see no stacktrace just a warning message which includes which application it was trying to connect to.

Current Logging

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 2011-11-22 00:16:11,711 WARN [StreamsCompletionService::thread-338] [AppLinksActivityProvider] Error fetching from /rest/activity-stream/1.0/config?local=true com.atlassian.sal.api.net.ResponseTransportException: Connection refused at com.atlassian.sal.core.net.HttpClientRequest.executeAndReturn(HttpClientRequest.java:315) at com.atlassian.plugins.rest.module.jersey.JerseyRequest.executeAndReturn(JerseyRequest.java:158) at com.atlassian.applinks.core.auth.ApplicationLinkRequestAdaptor.execute(ApplicationLinkRequestAdaptor.java:85) at com.atlassian.streams.internal.AppLinksActivityProvider.fetch(AppLinksActivityProvider.java:416) at com.atlassian.streams.internal.AppLinksActivityProvider.getFilters(AppLinksActivityProvider.java:228) at com.atlassian.streams.internal.ActivityProviderConnectionMonitorImpl$ActivityMonitorJob$1$1.call(ActivityProviderConnectionMonitorImpl.java:201) at com.atlassian.streams.internal.ActivityProviderConnectionMonitorImpl$ActivityMonitorJob$1$1.call(ActivityProviderConnectionMonitorImpl.java:198) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at com.atlassian.util.concurrent.LimitedExecutor$Runner.run(LimitedExecutor.java:96) at com.atlassian.sal.core.executor.ThreadLocalDelegateRunnable.run(ThreadLocalDelegateRunnable.java:34) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) Caused by: java.net.ConnectException: Connection refused at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:351) at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:213) at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:200) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:432) at java.net.Socket.connect(Socket.java:529) at sun.reflect.GeneratedMethodAccessor574.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.commons.httpclient.protocol.ReflectionSocketFactory.createSocket(ReflectionSocketFactory.java:139) at org.apache.commons.httpclient.protocol.DefaultProtocolSocketFactory.createSocket(DefaultProtocolSocketFactory.java:124) at org.apache.commons.httpclient.HttpConnection.open(HttpConnection.java:706) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:386) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:170) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:396) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:324) at com.atlassian.sal.core.net.HttpClientRequest.executeMethod(HttpClientRequest.java:479) at com.atlassian.sal.core.net.HttpClientRequest.executeAndReturn(HttpClientRequest.java:306) ... 16 more

Environment

None

Testing Notes

None

Status

Assignee

Joseph Walton

Reporter

Brydie McCoy

Labels

Add-on Type

None

Team

None

CC

None

Risk factor

None

QA Kickoff Status

None

QA Demo Status

None

Fix versions

Affects versions

5.0

Priority

Minor