Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: None
    • Labels:
      None

      Gliffy Diagrams

        Issue Links

          Activity

          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jwinters; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} James Winters added a comment -

          So to add to this, this is an extremely critical bug that we need to resolve. The Guice that SOY is using has a nasty bug in it http://code.google.com/p/guava-libraries/issues/detail?id=92, this essentially means none of the OSGI classloaders are freed. In JIRA 6.0 this translates into a 60MB leak. Since plugins 3.0 we actually provide an updated guice, this should be the preferred way to get hold of the library.

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jwinters; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} James Winters added a comment - So to add to this, this is an extremely critical bug that we need to resolve. The Guice that SOY is using has a nasty bug in it http://code.google.com/p/guava-libraries/issues/detail?id=92 , this essentially means none of the OSGI classloaders are freed. In JIRA 6.0 this translates into a 60MB leak. Since plugins 3.0 we actually provide an updated guice, this should be the preferred way to get hold of the library.
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: igrunert; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Ian Grunert added a comment -

          The pull request linked used the sisu-guice which is provided by plugins 3. We should re-open and merge that pull request.

          It failed to startup in stash, but it looks like that comment was made just before the plugins 3 upgrade was made in stash - https://stash.atlassian.com/projects/STASH/repos/stash/commits/7cc372956ae52092468adf9a9696803c9cda1786#pom.xml

          Also note that the soy version 2 upgrade was discussed in that pull request as being a potential problem for getting this into JIRA - that's already been done now so we shouldn't have any issues there.

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: igrunert; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Ian Grunert added a comment - The pull request linked used the sisu-guice which is provided by plugins 3. We should re-open and merge that pull request. It failed to startup in stash, but it looks like that comment was made just before the plugins 3 upgrade was made in stash - https://stash.atlassian.com/projects/STASH/repos/stash/commits/7cc372956ae52092468adf9a9696803c9cda1786#pom.xml Also note that the soy version 2 upgrade was discussed in that pull request as being a potential problem for getting this into JIRA - that's already been done now so we shouldn't have any issues there.
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: pslade; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Paul Slade added a comment -

          There is days in the loo on offer if we can make progress on this over the weekend. This is really coming late in 6.0.

          Can someone tell me when the memory leak was introduced? I want to know if Monday (with 6.0-rc2) is the first time we are going to see it in ondemand.

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: pslade; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Paul Slade added a comment - There is days in the loo on offer if we can make progress on this over the weekend. This is really coming late in 6.0. Can someone tell me when the memory leak was introduced? I want to know if Monday (with 6.0-rc2) is the first time we are going to see it in ondemand.
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jwinters; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} James Winters added a comment -

          It's been in the soy templates for a while, but introduced to JIRA on the 18th March via commit 6e87a093

          This was first built into the 6.0-OD 10 release - so it got shipped to OD on the 22-04-2013

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jwinters; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} James Winters added a comment - It's been in the soy templates for a while, but introduced to JIRA on the 18th March via commit 6e87a093 This was first built into the 6.0-OD 10 release - so it got shipped to OD on the 22-04-2013

            People

            • Assignee:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jwinters; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} James Winters
              Reporter:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jhinch; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Jason Hinch
            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Who's Looking?