Uploaded image for project: 'Atlassian Selenium'
  1. Atlassian Selenium
  2. SELENIUM-77

Allow TestedProducts to be extended with extra Guice Modules without having to implement your own TestedProduct

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Need a nice way to be able to extend the modules a TestedProduct uses so plugin devs can write their own modules without haveing to create their own TestedProduct.

        Attachments

          Activity

          Hide
          bbuchanan Ben Buchanan (Inactive) added a comment -

          Now that Jaie has left, Dariusz owns selenium/webdriver.

          Show
          bbuchanan Ben Buchanan (Inactive) added a comment - Now that Jaie has left, Dariusz owns selenium/webdriver.
          Hide
          jwesleysmith Jed Wesley-Smith added a comment -

          we have a new use-case for this, which is to inject our own timeouts into performance tests – we have brow-beaten/incentivated/pleaded Dariusz into considering finishing it!

          Show
          jwesleysmith Jed Wesley-Smith added a comment - we have a new use-case for this, which is to inject our own timeouts into performance tests – we have brow-beaten/incentivated/pleaded Dariusz into considering finishing it!
          Hide
          ahennecke Alexander Hennecke added a comment -

          Slight bug in that the Guice injector was replaced instead of appended, created pull request for fix at https://bitbucket.org/atlassian/atlassian-selenium/pull-request/1/selenium-77-fixed-broken-override-was

          Show
          ahennecke Alexander Hennecke added a comment - Slight bug in that the Guice injector was replaced instead of appended, created pull request for fix at https://bitbucket.org/atlassian/atlassian-selenium/pull-request/1/selenium-77-fixed-broken-override-was
          Hide
          dkordonski Dariusz Kordonski added a comment -

          thanks Alex, merged already. I'll keep it open to add some more tests.

          Show
          dkordonski Dariusz Kordonski added a comment - thanks Alex, merged already. I'll keep it open to add some more tests.
          Hide
          dkordonski Dariusz Kordonski added a comment -

          I didn't have bandwidth for more tests, FWIW it's still marked as experimental so we can always go back and fix anything we need, incl. changing the APIs around

          Show
          dkordonski Dariusz Kordonski added a comment - I didn't have bandwidth for more tests, FWIW it's still marked as experimental so we can always go back and fix anything we need, incl. changing the APIs around

            People

            • Assignee:
              dkordonski Dariusz Kordonski
              Reporter:
              jwilson jwilson (Inactive)
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 6 hours
                6h
                Remaining:
                Remaining Estimate - 6 hours
                6h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Who's Looking?