Uploaded image for project: 'Atlassian Selenium'
  1. Atlassian Selenium
  2. SELENIUM-203

Better APIs for creating custom TimedQueries and TimedConditions

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.1
    • Fix Version/s: 2.3.0
    • Component/s: pageobjects-elements
    • Labels:
      None

      Description

      Every now and then you have to create one. All you need is supplier of value and default timeout. There should be an injectable component to do this.

        Gliffy Diagrams

          Activity

          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment -

          This is critical, but really just an improvement. Can live without it until 2.3

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment - This is critical, but really just an improvement. Can live without it until 2.3
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: lmiranda; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Luis Miranda added a comment -

          I see there is a commit already but it's not getting shipped yet. This small improvement alone will make a big difference in how easy it is to use atlassian-selenium correctly in products.

          It would be good to get it out there ASAP.

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: lmiranda; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Luis Miranda added a comment - I see there is a commit already but it's not getting shipped yet. This small improvement alone will make a big difference in how easy it is to use atlassian-selenium correctly in products. It would be good to get it out there ASAP.
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment - - edited

          Luis Miranda not sure if you're aware of Conditions and Queries ? They already provide that API, it's just a bit inconvenient to use because they're all static methods that you need to provide an instance of Timeouts to (which can be @injected itself). This improvement is just about adding injectable components for more convenience

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment - - edited Luis Miranda not sure if you're aware of Conditions and Queries ? They already provide that API, it's just a bit inconvenient to use because they're all static methods that you need to provide an instance of Timeouts to (which can be @injected itself). This improvement is just about adding injectable components for more convenience
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: lmiranda; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Luis Miranda added a comment -

          Yup I'm aware of those despite the slightly different names.

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: lmiranda; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Luis Miranda added a comment - Yup I'm aware of those despite the slightly different names.
          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment -

          Impressive! Since you're so intimate with the API already and so keen on that change, why not contribute?

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment - Impressive! Since you're so intimate with the API already and so keen on that change, why not contribute?

            People

            • Assignee:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski
              Reporter:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Who's Looking?