Uploaded image for project: 'Atlassian Selenium'
  1. Atlassian Selenium
  2. SELENIUM-198

Allow for shutting down the drivers before shutdown hook

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently we have LifecycleAwareWebDriver grid that tries to kill the tracked drivers (==browsers) in a shutdown hook. Due to bugs in Selenium like:
      http://code.google.com/p/selenium/issues/detail?id=4733
      http://code.google.com/p/selenium/issues/detail?id=4734

      it doesn't work very well for some browsers. Let's allow test suites to do it themselves and provide a rule that will do it semi-automatically without involving a shutdown hook.

        Gliffy Diagrams

          Activity

          Hide
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment -

          This is not easily fixable. It seems that the drivers are improving their ability to shut down on JVM shut down without too much intervention from our side. SELENIUM-212 has made it such that our shut down hooks catch any exceptions thrown from quit optimistically assuming that the driver has been able to quit itself

          Show
          {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski added a comment - This is not easily fixable. It seems that the drivers are improving their ability to shut down on JVM shut down without too much intervention from our side. SELENIUM-212 has made it such that our shut down hooks catch any exceptions thrown from quit optimistically assuming that the driver has been able to quit itself

            People

            • Assignee:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski
              Reporter:
              {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: dkordonski; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Dariusz Kordonski
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Who's Looking?