AUI badge in sidebar missing border

Description

Another one, the AUI sidebar badges have lost their white border colour, and it looks like the code for it is still there, but it might be a mistake in the CSS since the border is set to the background colour `var(--aui-sidebar-badge-bg-color)` (instead of a border colour?)

Environment

None

QA Kickoff Check-In

Usage described in documentation
Demonstration of all states
Interactive state (screen readers)
Visual regression tests
Unit tests
Navigation (only keyboard / only mouse)
Component render legibly

QA Demo Check-Out

P2 plugin
Browsers (Edge/IE11/Firefox/Chrome/Safari)
Resizing
Zoom in/out
Navigation (Keyboard/Mouse)
Focus
Element status (At Rest/Pressed/Selected/Read Only/Disabled)
Cursors
Tooltips
Audio

Activity

Show:
Halp
April 13, 2021, 6:53 AM
Edited

There's a chance that when we designed it we didn't consider the active state. Which is very bad on us! I recall I've never been a fan of this border and I'd solve it with a pill's different background, but I also see the problem so I'd not oppose if you want to revert that change.

Chris "Daz" Darroch
April 13, 2021, 12:44 AM

I see that my commit message was: AUI-5094, AUI-5098: Dark theme for sidebar and badges.

Unfortunately this was over a year ago, and I can’t recall whether it was an ADG-driven design decision, something we wanted only for dark mode, or what. Perhaps will remember

I think the border helps with legibility, so happy for us to add it in, provided it’s what ADG / design want.

Halp
April 13, 2021, 12:24 AM

[On behalf of @gleal] @daz

Halp
April 13, 2021, 12:23 AM

[On behalf of @Matt] Interesting, I wonder why that is. It’s a lot harder to distinguish from the rest of the button

Gerardo Leal
April 13, 2021, 12:22 AM

Seems like these styles were changed intentionally to make the badges look “borderless”

, should we keep the styles or revert the border when in the sidebar?

Fixed

Assignee

Gerardo Leal

Reporter

Halp

Labels