Increase importance of assistive CSS rule

Description

Hi team :uwuwave: The `assistive` labels added by AUI 9 are supposed to be invisible on the layout for sighted users, but when an inline dialog is rendered within a radio option, the radio label style overrides its position from `absolute` to `relative`, which makes the `assistive` label visible (Enter a branch name here is supposed to be hidden)

Environment

None

QA Kickoff Check-In

Usage described in documentation
Demonstration of all states
Interactive state (screen readers)
Visual regression tests
Unit tests
Navigation (only keyboard / only mouse)
Component render legibly

QA Demo Check-Out

P2 plugin
Browsers (Edge/IE11/Firefox/Chrome/Safari)
Resizing
Zoom in/out
Navigation (Keyboard/Mouse)
Focus
Element status (At Rest/Pressed/Selected/Read Only/Disabled)
Cursors
Tooltips
Audio

Activity

Show:
Halp
April 14, 2021, 12:49 PM

[On behalf of @mkonopka] right, give me a second

Halp
April 14, 2021, 12:48 PM

[On behalf of @Matt] is it missing one file change? Can’t see the diff for `.assistive` made `!important`

Halp
April 14, 2021, 12:47 PM

[On behalf of @mkonopka] both, for assistive and other .radio usecases

Halp
April 14, 2021, 12:46 PM
Edited

<https://bitbucket.org/atlassian/aui/pull-requests/2900>

Halp
April 14, 2021, 9:50 AM
Edited

Yeah I had suggested `!important` styling in the assistive class selector as a fix. Either way, I do know our UI for this page is total crap, no need to say it any other way. It was done ages ago, and yes it was done with designers at the time (well before I joined the company). I don't want to judge too much on old patterns... I can say for sure that I will not get extra budget to redo the HTML of that page. If we ever did, that would be in favour of an Atlaskit rewrite. I am happy with you guys just closing the ticket with no action, as I said, we have fixed the problem in a different fashion. I just thought that this would deserve to be fixed in the library itself because it can impact other use cases.

Fixed

Assignee

Marcin Konopka

Reporter

Halp

Labels