net.java.ao.db.SQLServerDatabaseProvider#setQueryResultSetProperties is not converting from zero-based to one-based

Description

java.sql.ResultSet#absolute is one-based yet net.java.ao.db.SQLServerDatabaseProvider#setQueryResultSetProperties uses the zero based net.java.ao.Query#getOffset without converting it. If net.java.ao.Query#getOffset is in-fact suppose to be one-based then net.java.ao.db.SQLServerDatabaseProvider#renderQuerySelect is incorrect as it assumes it is zero-based. It also should be clearly documented

Environment

None

Testing Notes

None

Status

Assignee

Unassigned

Reporter

jhinch

Labels

None

Add-on Type

None

Team

None

CC

None

Risk factor

None

QA Kickoff Status

None

QA Demo Status

None

Story Points

0.5

Components

Priority

Critical
Configure