New JIRA plugins should have source encoding and compiler version

Description

  1. Generate a plugin for the current JIRA version using atlas-create-jira-plugin.

  2. Run mvn compile

The console shows this warning:

It's a Maven best practice to set this via a build property:

The console also shows a warning about the compiler plugin version not being set.

We should demonstrate good craftsmanship to plugin developers by fixing these faux pas.

Environment

ATLAS Version: 5.1.10
ATLAS Home: /usr/local/Cellar/atlassian-plugin-sdk/5.1.10/libexec
ATLAS Scripts: /usr/local/Cellar/atlassian-plugin-sdk/5.1.10/libexec/bin
ATLAS Maven Home: /usr/local/Cellar/atlassian-plugin-sdk/5.1.10/libexec/apache-maven-3.2.1
AMPS Version: 5.1.18
--------
Executing: /usr/local/bin/mvn --version -gs /usr/local/Cellar/atlassian-plugin-sdk/5.1.10/libexec/apache-maven-3.2.1/conf/settings.xml
[MVNVM] Using maven: 3.2.5
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T04:29:23+11:00)
Maven home: /Users/aswan/.mvnvm/apache-maven-3.2.5
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.10.5", arch: "x86_64", family: "mac"

Testing Notes

None

Activity

Show:
Andrew S
October 22, 2015, 4:46 AM

Indeed, thanks for noting this.

Alex Courtis
October 22, 2015, 4:44 AM

Should be done for all products, not just JIRA

Andrew S
September 30, 2015, 10:22 PM
Edited

I'm reopening this because:

  • The originally reported problem (the POM doesn't specify the source encoding) still happens:

  • There's a new problem in that the POM doesn't specify the version of the compiler plugin, which causes this warning at compile time:

I have:

  • updated the issue summary and description to reflect both bugs

  • updated the Environment field to reflect the version of AMPS in which I retested this

  • attached the generated POM, for easy reference

Marcos Scriven
September 30, 2015, 9:38 AM

Unfortunately we have a large backlog of issues in AMPS, and are now trying to prioritise them. We have thus closed this issue with the resolution Timed Out because:

  • It has had no activity in the past six months.

  • Has no more than one watcher or voter.

If you feel this issue is still relevant, then please feel free to reopen it. You can do this my clicking the Reopen Issue button at the top of the issue view.

If you do decide to reopen it, then you can really help us out by:

  • Trying version 5.0.25 of AMPS or stating why you can't upgrade. (Note if you're moving from 4.x you'll need to be on Maven 3.1 or above)

  • Checking the issue still occurs, attaching recent logs.

  • Making sure the title of the issue is as descriptive as possible.

  • Ensuring full and clear steps to reproduce are in the description.

  • Adding a comment with any current updates or further info.

We apologise we've not been able to look at your issue directly.

Fixed

Assignee

Unassigned

Reporter

Andrew S