Uploaded image for project: 'Atlassian Connect'
  1. Atlassian Connect
  2. AC-643

Connect add-ons should be provided with unique user key information in requests from Atlassian products that support user renaming

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Outgoing requests from the Atlassian application to a Connect add-on typically include information in the request that identifies the user context of the request. This is done by specifying the username of the user that initiated the request.

      Some connect add-ons may use this user context to associate Atlassian users with their own user-base.

      Now that some Atlassian applications (ie. Confluence & JIRA) support renaming users, the Connect add-on needs to be provided with this additional user context. In other words, the Connect add-on needs to be able to uniquely identify each Atlassian user, and the username alone is no longer enough information to do this.

      Possible solutions include providing the unique user key along with the username in outgoing requests from Atlassian apps, or publishing a webhook to the Connect add-on whenever a username is changed.

        Gliffy Diagrams

          Issue Links

            Activity

            Show
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark added a comment - Created https://bitbucket.org/atlassian/node-feebs/issue/27/send-delegated-oauth-requests-to & https://bitbucket.org/sleberrigaud_atlassian/ac-play-java/issue/1/send-delegated-oauth-requests-to
            Hide
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: raimonds.simanovskis; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Raimonds Simanovskis added a comment -

            Currently remote_plugin_enabled webhook is passing user_id parameter to AC add-on. It would be better if user_key parameter would be passed in this case as well.

            Show
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: raimonds.simanovskis; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Raimonds Simanovskis added a comment - Currently remote_plugin_enabled webhook is passing user_id parameter to AC add-on. It would be better if user_key parameter would be passed in this case as well.
            Hide
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark added a comment -

            Good catch. I forgot to fix up webhooks as part of this change. I'll raise this as a new issue.

            Show
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark added a comment - Good catch. I forgot to fix up webhooks as part of this change. I'll raise this as a new issue.
            Hide
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: raimonds.simanovskis; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Raimonds Simanovskis added a comment -

            In addition noticed that if I use <general-page> with <condition> with url attribute then this condition url request also gets just user_id parameter and no user_key parameter.

            Show
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: raimonds.simanovskis; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Raimonds Simanovskis added a comment - In addition noticed that if I use <general-page> with <condition> with url attribute then this condition url request also gets just user_id parameter and no user_key parameter.
            Hide
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark added a comment -

            I created AC-688 and AC-689 for the two additional locations where user_key should be used.

            Show
            {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark added a comment - I created AC-688 and AC-689 for the two additional locations where user_key should be used.

              People

              • Assignee:
                {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark
                Reporter:
                {annotationCollection: [{}], annotations: [{}], collectionInheritableAnnotations: [{}], declaredAnnotations: [{}], description: Annotated value: jclark; Annotations: [@com.atlassian.velocity.htmlsafe.HtmlSafe()]} Joseph Clark
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Who's Looking?